Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metadb): handle decimals #25921

Merged
merged 2 commits into from
Nov 21, 2023
Merged

feat(metadb): handle decimals #25921

merged 2 commits into from
Nov 21, 2023

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Nov 9, 2023 •
edited
Loading

SUMMARY

Add support for decimals to the meta database.

Note: this requires updating Shillelagh to 1.2.10, since it needs to convert between decimals and string for SQLite.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida mentioned this pull request Nov 9, 2023
Closed
@pull-request-size pull-request-size bot added size/XL and removed size/S labels Nov 9, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fbc66a8) 58.90% compared to head (757bff4) 69.08%.

Files Patch % Lines
superset/extensions/metadb.py 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #25921       +/-   ##
===========================================
+ Coverage   58.90%   69.08%   +10.17%     
===========================================
  Files        1941     1941               
  Lines       75882    75891        +9     
  Branches     8443     8443               
===========================================
+ Hits        44700    52431     +7731     
+ Misses      29007    21285     -7722     
  Partials     2175     2175
Flag Coverage Δ
hive 53.68% <80.00%> (+<0.01%) ⬆️
javascript 56.27% <ø> (ø)
mysql 78.16% <80.00%> (?)
postgres 78.26% <80.00%> (?)
presto 53.64% <80.00%> (+<0.01%) ⬆️
python 82.91% <90.00%> (+21.16%) ⬆️
sqlite 76.91% <80.00%> (?)
unit 55.75% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 18, 2023
@betodealmeida betodealmeida force-pushed the fix-numeric branch 4 times, most recently from 0462c53 to d547f90 Compare November 21, 2023 14:52
@pull-request-size pull-request-size bot added size/S and removed size/M labels Nov 21, 2023
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 21, 2023
@betodealmeida betodealmeida merged commit f99c874 into master Nov 21, 2023
54 checks passed
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@betodealmeida @josedev-union
feat(metadb): handle decimals (apache#25921)
0aa1994
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@betodealmeida
feat(metadb): handle decimals (apache#25921)
0b3866b
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@betodealmeida @sfirke
feat(metadb): handle decimals (apache#25921)
74b16a3
@mistercrunch mistercrunch deleted the fix-numeric branch March 26, 2024 18:06
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@betodealmeida
feat(metadb): handle decimals (apache#25921)
c7f669d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betodealmeida @john-bodley @eschutho @mistercrunch